0001063: cannot save tonemapped low dynamic range image

(0003007)
SATtva (developer)
2011-05-09 00:47

What's you OS? Which image type are you trying to save?

(0003008)
damir3004 (reporter)
2011-05-09 02:24

I'm running:
Ubuntu 11.04 x64
Blender 2.57b official release

I'm trying to save a 'Tonemapped Low Dynamic Range Image (PNG), it is the first option from 'File -> Export to Image'.
I tried different folders on my Ubuntu so it has nothing to do with write permissions I think.

(0003009)
SATtva (developer)
2011-05-09 02:28

You need to specify a file extension in addition to its name, i.e. "image.png", not just "image". Hopefully this limitation will be addressed in the future.

(0003010)
damir3004 (reporter)
2011-05-09 02:53

Okay, that was the problem. I guess a fix for this will be included in some future release right? Thanks anyways.

(0003322)
Omniflux (developer)
2012-01-19 20:43

I cannot reproduce this in Windows. A side effect of QT using the system dialogs? Windows appears to append the extension from the currently selected filter.

Can someone confirm this is still an issue in linux?

(0003326)
SATtva (developer)
2012-01-20 07:26

Yes, it is. I can confirm the problem with LDR and HDR image export dialogs. Save FLM dialog is fine -- filename already has .flm extension.

(0003327)
Omniflux (developer)
2012-01-20 18:15

Do you think always defaulting to PNG when no extension is given would be sane?

(0003328)
Lord Crc (administrator)
2012-01-20 23:43

Isn't there some way in Qt to have a default extension for the file dialog box, and have it append this if not any is given?

(0003330)
Omniflux (developer)
2012-01-21 16:42

I believe QFileDialog::setDefaultSuffix() does this. However, in Windows, the windows file dialog will automatically append the extension selected in the dialogs filter:

"PNG Image (*.png);;JPEG Image (*.jpg);;Windows Bitmap (*.bmp);;TIFF Image (*.tif)"

Linux (and possibly MacOS) does not do this. If we use setDefaultSuffix, we must decide on a default to use.

(0003331)
Lord Crc (administrator)
2012-01-21 23:12

I think PNG is the easily the obvious choice there.

(0003342)
Omniflux (developer)
2012-01-29 15:18

Just tested and QFileDialog::setDefaultSuffix() cannot be used unless we switch from the native dialog box to the Qt dialog.

The other option is to append the default extension to the string returned by the dialog if an extension is not specified. This means we have to check for the overwrite condition our self, prompt the user, and throw them back into the getSaveFileName dialog if they select no which is not quite as clean as the default overwrite checking.

Either way, we should probably be checking the extension to ensure it is one QImage supports since we are using QImages auto detection by filename in the call to save.

(0003550)
jeanphi (administrator)
2012-08-21 13:09

If the file extension doesn't match a known extension for the selected filter, add the default extension of the selected filter.

Issue History
Date Modified	Username	Field	Change
2011-05-08 14:58	damir3004	New Issue
2011-05-09 00:47	SATtva	Note Added: 0003007
2011-05-09 02:24	damir3004	Note Added: 0003008
2011-05-09 02:28	SATtva	Note Added: 0003009
2011-05-09 02:53	damir3004	Note Added: 0003010
2011-05-09 12:29	damir3004	Severity	block => major
2011-05-24 12:55	jeanphi	Target Version	=> 1.0
2012-01-19 20:43	Omniflux	Note Added: 0003322
2012-01-20 07:26	SATtva	Note Added: 0003326
2012-01-20 18:15	Omniflux	Note Added: 0003327
2012-01-20 23:43	Lord Crc	Note Added: 0003328
2012-01-21 16:42	Omniflux	Note Added: 0003330
2012-01-21 23:12	Lord Crc	Note Added: 0003331
2012-01-29 15:18	Omniflux	Note Added: 0003342
2012-08-21 13:08	jeanphi	Assigned To	=> jeanphi
2012-08-21 13:08	jeanphi	Status	new => assigned
2012-08-21 13:09	jeanphi	Note Added: 0003550
2012-08-21 13:09	jeanphi	Status	assigned => resolved
2012-08-21 13:09	jeanphi	Fixed in Version	=> 1.0RC4
2012-08-21 13:09	jeanphi	Resolution	open => fixed
2012-09-11 06:10	jeanphi	Status	resolved => closed

Notes
(0003007) SATtva (developer) 2011-05-09 00:47	What's you OS? Which image type are you trying to save?

(0003008) damir3004 (reporter) 2011-05-09 02:24	I'm running: Ubuntu 11.04 x64 Blender 2.57b official release I'm trying to save a 'Tonemapped Low Dynamic Range Image (PNG), it is the first option from 'File -> Export to Image'. I tried different folders on my Ubuntu so it has nothing to do with write permissions I think.

(0003009) SATtva (developer) 2011-05-09 02:28	You need to specify a file extension in addition to its name, i.e. "image.png", not just "image". Hopefully this limitation will be addressed in the future.

(0003010) damir3004 (reporter) 2011-05-09 02:53	Okay, that was the problem. I guess a fix for this will be included in some future release right? Thanks anyways.

(0003322) Omniflux (developer) 2012-01-19 20:43	I cannot reproduce this in Windows. A side effect of QT using the system dialogs? Windows appears to append the extension from the currently selected filter. Can someone confirm this is still an issue in linux?

(0003326) SATtva (developer) 2012-01-20 07:26	Yes, it is. I can confirm the problem with LDR and HDR image export dialogs. Save FLM dialog is fine -- filename already has .flm extension.

(0003327) Omniflux (developer) 2012-01-20 18:15	Do you think always defaulting to PNG when no extension is given would be sane?

(0003328) Lord Crc (administrator) 2012-01-20 23:43	Isn't there some way in Qt to have a default extension for the file dialog box, and have it append this if not any is given?

(0003330) Omniflux (developer) 2012-01-21 16:42	I believe QFileDialog::setDefaultSuffix() does this. However, in Windows, the windows file dialog will automatically append the extension selected in the dialogs filter: "PNG Image (.png);;JPEG Image (.jpg);;Windows Bitmap (.bmp);;TIFF Image (.tif)" Linux (and possibly MacOS) does not do this. If we use setDefaultSuffix, we must decide on a default to use.

(0003331) Lord Crc (administrator) 2012-01-21 23:12	I think PNG is the easily the obvious choice there.

(0003342) Omniflux (developer) 2012-01-29 15:18	Just tested and QFileDialog::setDefaultSuffix() cannot be used unless we switch from the native dialog box to the Qt dialog. The other option is to append the default extension to the string returned by the dialog if an extension is not specified. This means we have to check for the overwrite condition our self, prompt the user, and throw them back into the getSaveFileName dialog if they select no which is not quite as clean as the default overwrite checking. Either way, we should probably be checking the extension to ensure it is one QImage supports since we are using QImages auto detection by filename in the call to save.

(0003550) jeanphi (administrator) 2012-08-21 13:09	If the file extension doesn't match a known extension for the selected filter, add the default extension of the selected filter.

Relationships