Film - the bottleneck

Discussion related to the implementation of new features & algorithms to the Core Engine.

Moderators: jromang, tomb, zcott, coordinators

Re: Film - the bottleneck

Postby SATtva » Fri Feb 03, 2012 1:06 pm

Lord Crc wrote:Want me to keep it in the test branch or?

I'd be glad to see it in the trunk. Frankly, this is the only thing keeping me from making the new weeklies. :)
Linux builds packager
聞くのは一時の恥、聞かぬのは一生の恥
User avatar
SATtva
Developer
 
Posts: 6217
Joined: Tue Apr 07, 2009 12:19 pm
Location: from Siberia with love

Re: Film - the bottleneck

Postby Lord Crc » Fri Feb 03, 2012 3:33 pm

SATtva wrote:I'd be glad to see it in the trunk. Frankly, this is the only thing keeping me from making the new weeklies. :)


Well... I felt frisky, I've pushed the merge. Here goes nothing...

It compiles here, and for all I can see works :D but may be some issues still.

edit: Some initial banding is to be expected, since some buffers may not be filled before the initial tonemap. I think we need to add some more flushing before outputting images, I'll try to get this sorted ASAP.
May contain traces of nuts.
User avatar
Lord Crc
Developer
 
Posts: 4932
Joined: Sat Nov 17, 2007 2:10 pm

Re: Film - the bottleneck

Postby binarycortex » Fri Feb 03, 2012 10:15 pm

HOLY COMMIT MESSAGE BATMAN! What was that, a novel.

Edit: That's even funnier because of your avatar. :D
Competition Coordinator.
Current Competition: Math is Beautiful / Abstract Wallpaper

Member of the first official jeanphi-fan club
User avatar
binarycortex
Developer
 
Posts: 1538
Joined: Fri Feb 22, 2008 10:44 pm

Re: Film - the bottleneck

Postby Lord Crc » Sat Feb 04, 2012 12:19 am

Hehe, well guibou wanted more text ;)

I'll add some more comments to the film code once we're satisfied with most of it.
May contain traces of nuts.
User avatar
Lord Crc
Developer
 
Posts: 4932
Joined: Sat Nov 17, 2007 2:10 pm

Re: Film - the bottleneck

Postby SATtva » Sat Feb 04, 2012 4:09 am

Awesome! Thanks a lot. :)

binarycortex wrote:HOLY COMMIT MESSAGE BATMAN!

:lol:
Linux builds packager
聞くのは一時の恥、聞かぬのは一生の恥
User avatar
SATtva
Developer
 
Posts: 6217
Joined: Tue Apr 07, 2009 12:19 pm
Location: from Siberia with love

Re: Film - the bottleneck

Postby Pilchard123 » Sat Feb 04, 2012 4:29 am

Some days, you just can't get rid of a bug!
Pilchard123
 
Posts: 475
Joined: Sun Oct 30, 2011 8:05 am

Re: Film - the bottleneck

Postby Lord Crc » Sat May 26, 2012 11:33 am

Just wanted to add this encouraging info thanks to JtheNinja, who managed to run some tests on a machine with dual Xeon X5670's for a total of 24 threads.

Setting tiles=1 effectively reverts the code to the old behavior, while tiles=0 lets the code decide the number of tiles to use. The "k=5" is the outlier/firefly rejection parameter, 0 disables it.

<JtheNinja> LordCrc: so i just tested your tiled buffer on a 24 thread machine
<JtheNinja> tiles=1, k=5, ~250ks/s
<JtheNinja> tiles=1, k=0, ~600ks/s
<JtheNinja> tiles=0, k=5, ~750ks/s
<JtheNinja> tiles=0, k=0, ~950ks/s


So, even with outlier rejection disabled we're seeing a very nice speed increase of almost 60%, and with outlier rejection it's a massive 200% increase.
May contain traces of nuts.
User avatar
Lord Crc
Developer
 
Posts: 4932
Joined: Sat Nov 17, 2007 2:10 pm

Re: Film - the bottleneck

Postby jeanphi » Sat May 26, 2012 2:11 pm

Hi,

Some would call it an achievement. Nice job!
It also sets things straight: with one good algorithmic decision you win more than all the micro optimizations we can do.

Jeanphi
jeanphi
Developer
 
Posts: 7312
Joined: Mon Jan 14, 2008 7:21 am

Re: Film - the bottleneck

Postby xsl » Fri Aug 17, 2012 5:08 pm

Hi,

I was doing some tests with Amazon EC2 instances and it looks like I'm hitting this bottleneck even with the new code (1.0 RC3). I was getting strange (very low) performances when running a cc2.8large instance (2 x Intel Xeon E5-2670, eight-core "Sandy Bridge", 32 threads). See this post and the next for the details. The short of it is that I had to run 6 slaves on this instance to max it out. My image was small (960x540) so I'm sure it's contributing factor.

Could there be something else going on?
xsl
 
Posts: 85
Joined: Mon Mar 01, 2010 9:42 am

Re: Film - the bottleneck

Postby Lord Crc » Fri Aug 17, 2012 5:19 pm

xsl wrote:The short of it is that I had to run 6 slaves on this instance to max it out. My image was small (960x540) so I'm sure it's contributing factor.


Yes, that is likely the cause. I'll see about making the "tiles", or slabs rather, vertical instead of horizontal, given that most people render wide images. Increase the resolution and you should see it scaling better.
May contain traces of nuts.
User avatar
Lord Crc
Developer
 
Posts: 4932
Joined: Sat Nov 17, 2007 2:10 pm

PreviousNext

Return to Architecture & Design

Who is online

Users browsing this forum: No registered users and 0 guests