Camera response functions as a tonemapping option

Discussion related to the implementation of new features & algorithms to the Core Engine.

Moderators: jromang, tomb, zcott, coordinators

Re: Camera response functions as a tonemapping option

Postby pciccone » Sat Nov 20, 2010 4:29 pm

Thanks!
User avatar
pciccone
Developer
 
Posts: 686
Joined: Wed Jan 13, 2010 11:02 am
Location: California

Re: Camera response functions as a tonemapping option

Postby tomb » Sat Nov 20, 2010 4:49 pm

Pushed
User avatar
tomb
Developer
 
Posts: 1919
Joined: Thu Oct 11, 2007 4:23 pm
Location: Oslo, Norway

Re: Camera response functions as a tonemapping option

Postby ralvision » Sun Nov 21, 2010 3:17 am

Film Response is a good name, accurate in it's description. I'm loving that these latest options save me 3-5 steps in a typical Photoshop post-production for a Lux image, & sometimes eliminate the need for post work to achieve the desired look. I know there has been some discussion about the GUI in terms of the CRF/FR option, so here's my 2 cents :)
- Could the existing list of CRFs be integrated into Lux as a dropdown list where the CRF name resides when loaded? The load button could then be used for additional CRF files that become available later on.
lux-crfdropdown.jpg
Sample CRF/Film Response dropdown UI


- Could the option be added to save user defined color spaces/gamma & other user settings into a user preset that can be recalled & applied to a new render in 1 click? (possibly adding a user preset dropdown field or menu item for the saved presets)

- There is a noise reduction function, but could a gaussian noise/grain filter be added to add a layer of "film grain", not unlike what you find in Photoshop Lightrom 3.0? Lightroom gives grain amount. size & roughness parameters. I'm thinking about options that reduce the need to turn to a third party program to give some creative control, without going nuts :lol: .
“Light glorifies everything. It transforms and ennobles the most commonplace and ordinary subjects. The object is nothing, light is everything.” – Leonard Missone
User avatar
ralvision
 
Posts: 21
Joined: Wed Aug 25, 2010 8:05 pm

Re: Camera response functions as a tonemapping option

Postby patro » Sun Nov 21, 2010 5:21 am

ralvision wrote:.......................................

I agree with your requests
User avatar
patro
 
Posts: 1798
Joined: Fri Feb 29, 2008 9:06 pm
Location: mount Etna

Re: Camera response functions as a tonemapping option

Postby Lord Crc » Thu Nov 25, 2010 5:05 pm

ralvision wrote:- Could the existing list of CRFs be integrated into Lux as a dropdown list where the CRF name resides when loaded? The load button could then be used for additional CRF files that become available later on.
- Could the option be added to save user defined color spaces/gamma & other user settings into a user preset that can be recalled & applied to a new render in 1 click? (possibly adding a user preset dropdown field or menu item for the saved presets)


The CRF dropdown has been discussed, we have some different ways to solve this. Second one should also be possible, but then the exporter stuff comes into play ie should the data be shared with the exporters, if so how... Feel free to make a task in mantis so we don't forget about this though :)

ralvision wrote:- There is a noise reduction function, but could a gaussian noise/grain filter be added to add a layer of "film grain", not unlike what you find in Photoshop Lightrom 3.0? Lightroom gives grain amount. size & roughness parameters. I'm thinking about options that reduce the need to turn to a third party program to give some creative control, without going nuts :lol: .


So after you've rendered for a week you want to add noise back? :lol: This won't be a priority task right now, but will fit nicely once we refactor the imaging pipeline. Please put it in mantis so we can have a discussion and it doesn't become lost.
May contain traces of nuts.
User avatar
Lord Crc
Developer
 
Posts: 4455
Joined: Sat Nov 17, 2007 2:10 pm

Re: Camera response functions as a tonemapping option

Postby jeanphi » Thu Nov 25, 2010 6:09 pm

Lord Crc wrote:So after you've rendered for a week you want to add noise back? :lol: This won't be a priority task right now, but will fit nicely once we refactor the imaging pipeline. Please put it in mantis so we can have a discussion and it doesn't become lost.

The core currently allows it through the dithering parameters of ApplyImagingPipeline :) It's just that we don't make use of those...

Jeanphi
jeanphi
Developer
 
Posts: 6577
Joined: Mon Jan 14, 2008 7:21 am

Re: Camera response functions as a tonemapping option

Postby Lord Crc » Thu Nov 25, 2010 6:33 pm

Oh yeah forgotten about that, still if you want to adjust grain size etc we clearly need something more advanced :)
May contain traces of nuts.
User avatar
Lord Crc
Developer
 
Posts: 4455
Joined: Sat Nov 17, 2007 2:10 pm

Re: Camera response functions as a tonemapping option

Postby ralvision » Mon Nov 29, 2010 5:52 pm

Lord Crc wrote:
ralvision wrote:- There is a noise reduction function, but could a gaussian noise/grain filter be added to add a layer of "film grain", not unlike what you find in Photoshop Lightrom 3.0? Lightroom gives grain amount. size & roughness parameters. I'm thinking about options that reduce the need to turn to a third party program to give some creative control, without going nuts :lol: .


So after you've rendered for a week you want to add noise back? :lol: This won't be a priority task right now, but will fit nicely once we refactor the imaging pipeline. Please put it in mantis so we can have a discussion and it doesn't become lost.


:) Just as everyone wants clean renders, here I come to dirty them up! :lol: For 35+ years, my discipline in the digital realm of editing, graphics, video & photography today, has been shaped by the language & aesthetic of film. Our brains have been trained to accept the subtle character of film, grain, DOF, etc... in conveying "realness" in the captured image. So many of the features of Luxrender support these characteristics, HDRI, material layering for proper surface response to light, and most importantly, the accurate calculation of light itself. So my humble suggestion is to work in one or two more aspects as the project will allow. I am a huge proponent of realism, & photo-reality in digital rendering, which is why I am so excited by this project. As asked I've added this & the CRF/FR options suggestion to Mantis to keep them on the radar.

Thanks to everyone involved, & continued success!
“Light glorifies everything. It transforms and ennobles the most commonplace and ordinary subjects. The object is nothing, light is everything.” – Leonard Missone
User avatar
ralvision
 
Posts: 21
Joined: Wed Aug 25, 2010 8:05 pm

Re: Camera response functions as a tonemapping option

Postby patro » Sat Dec 04, 2010 7:43 pm

Hi,
in latest window 32 weekly build I noticed that the new camera response let Luxrender crash.
this happens instantly when pushing the button while trying to load just the first file... or when you try to load repetitively other file.
had any one same issue?
User avatar
patro
 
Posts: 1798
Joined: Fri Feb 29, 2008 9:06 pm
Location: mount Etna

Re: Camera response functions as a tonemapping option

Postby Lord Crc » Sun Dec 05, 2010 5:12 am

patro wrote:in latest window 32 weekly build I noticed that the new camera response let Luxrender crash.
had any one same issue?


Works fine here, at least for the few CRF's I tried. Does it happen to all CRF's or only a few specific? Does it happen with a different resolution?
May contain traces of nuts.
User avatar
Lord Crc
Developer
 
Posts: 4455
Joined: Sat Nov 17, 2007 2:10 pm

PreviousNext

Return to Architecture & Design

Who is online

Users browsing this forum: Kunibert_KA and 1 guest