Page 5 of 6

Re: Film - the bottleneck

PostPosted: Fri Feb 03, 2012 1:06 pm
by SATtva
Lord Crc wrote:Want me to keep it in the test branch or?

I'd be glad to see it in the trunk. Frankly, this is the only thing keeping me from making the new weeklies. :)

Re: Film - the bottleneck

PostPosted: Fri Feb 03, 2012 3:33 pm
by Lord Crc
SATtva wrote:I'd be glad to see it in the trunk. Frankly, this is the only thing keeping me from making the new weeklies. :)


Well... I felt frisky, I've pushed the merge. Here goes nothing...

It compiles here, and for all I can see works :D but may be some issues still.

edit: Some initial banding is to be expected, since some buffers may not be filled before the initial tonemap. I think we need to add some more flushing before outputting images, I'll try to get this sorted ASAP.

Re: Film - the bottleneck

PostPosted: Fri Feb 03, 2012 10:15 pm
by binarycortex
HOLY COMMIT MESSAGE BATMAN! What was that, a novel.

Edit: That's even funnier because of your avatar. :D

Re: Film - the bottleneck

PostPosted: Sat Feb 04, 2012 12:19 am
by Lord Crc
Hehe, well guibou wanted more text ;)

I'll add some more comments to the film code once we're satisfied with most of it.

Re: Film - the bottleneck

PostPosted: Sat Feb 04, 2012 4:09 am
by SATtva
Awesome! Thanks a lot. :)

binarycortex wrote:HOLY COMMIT MESSAGE BATMAN!

:lol:

Re: Film - the bottleneck

PostPosted: Sat Feb 04, 2012 4:29 am
by Pilchard123
Some days, you just can't get rid of a bug!

Re: Film - the bottleneck

PostPosted: Sat May 26, 2012 11:33 am
by Lord Crc
Just wanted to add this encouraging info thanks to JtheNinja, who managed to run some tests on a machine with dual Xeon X5670's for a total of 24 threads.

Setting tiles=1 effectively reverts the code to the old behavior, while tiles=0 lets the code decide the number of tiles to use. The "k=5" is the outlier/firefly rejection parameter, 0 disables it.

<JtheNinja> LordCrc: so i just tested your tiled buffer on a 24 thread machine
<JtheNinja> tiles=1, k=5, ~250ks/s
<JtheNinja> tiles=1, k=0, ~600ks/s
<JtheNinja> tiles=0, k=5, ~750ks/s
<JtheNinja> tiles=0, k=0, ~950ks/s


So, even with outlier rejection disabled we're seeing a very nice speed increase of almost 60%, and with outlier rejection it's a massive 200% increase.

Re: Film - the bottleneck

PostPosted: Sat May 26, 2012 2:11 pm
by jeanphi
Hi,

Some would call it an achievement. Nice job!
It also sets things straight: with one good algorithmic decision you win more than all the micro optimizations we can do.

Jeanphi

Re: Film - the bottleneck

PostPosted: Fri Aug 17, 2012 5:08 pm
by xsl
Hi,

I was doing some tests with Amazon EC2 instances and it looks like I'm hitting this bottleneck even with the new code (1.0 RC3). I was getting strange (very low) performances when running a cc2.8large instance (2 x Intel Xeon E5-2670, eight-core "Sandy Bridge", 32 threads). See this post and the next for the details. The short of it is that I had to run 6 slaves on this instance to max it out. My image was small (960x540) so I'm sure it's contributing factor.

Could there be something else going on?

Re: Film - the bottleneck

PostPosted: Fri Aug 17, 2012 5:19 pm
by Lord Crc
xsl wrote:The short of it is that I had to run 6 slaves on this instance to max it out. My image was small (960x540) so I'm sure it's contributing factor.


Yes, that is likely the cause. I'll see about making the "tiles", or slabs rather, vertical instead of horizontal, given that most people render wide images. Increase the resolution and you should see it scaling better.