LuxCore: render engine unification

Discussion related to the implementation of new features & algorithms to the Core Engine.

Moderators: Dade, jromang, tomb, zcott, coordinators

Re: LuxCore: render engine unification

Postby sharlybg » Mon Feb 13, 2017 8:08 am

Dade wrote:I have done:

Dade wrote:

Rename BIASPATHOCL in TILEPATHOCL;
Rename BIASPATHCPU in TILEPATHCPU;
Rename BIASPATHSAMPLER in TILEPATHSAMPLER;
Drop RTPATHOCL;
Rename RTBIASPATHOCL in RTPATHOCL;



and working on:

Dade wrote:

Make TILEPATHCPU works exactly like TILEPATHOCL (at the moment it has still the support for path split, something not supported by TILEPATHOCL);



NOTE: I have renamed any reference to "bias" into "tile", including symbols like BIASPATHSAMPLER and properties like "bisapth.*" into "tilepath.*", "stats.biaspath.*" into "stats.tilepath.*", etc. It should be quiete easy to update any code using LuxCore API by just searching for any occurrence of "bias" string inside the sources.


wow you rock ! WAR MACHINE - DEV.MACHINE
i7 6700k + 32 Gb DDR4 + 2X R9 390 sapphir nitro.
User avatar
sharlybg
 
Posts: 687
Joined: Tue Nov 02, 2010 10:22 am
Location: Ivory coast

Re: LuxCore: render engine unification

Postby burnin » Mon Feb 13, 2017 10:01 am

woow :D yes
same thoughts here, sounds like a good & solid plan

already in motion :o
respect
burnin
 
Posts: 252
Joined: Mon May 03, 2010 8:04 pm

Re: LuxCore: render engine unification

Postby Dade » Thu Feb 16, 2017 11:25 am

Now TILEPATHCPU works exactly like TILEPATHOCL and all path tracers (i.e. PATHCPU, PATHOCL, RTPATHCPU, RTPATHOCL, TILEPATHCPU, TILEPATHOCL) uses the same set of properties:

Code: Select all
# The default values (note: RT modes uses lower max. depths to run faster)
path.pathdepth.total = 6
path.pathdepth.diffuse = 4
path.pathdepth.glossy = 4
path.pathdepth.specular = 6
path.russianroulette.depth = 3
path.russianroulette.cap = 0.5
path.clamping.variance.maxvalue = 0.0
path.forceblackbackground.enable = false


Plus some render engine specific setting.

PATHOCL

Code: Select all
# The default values
pathocl.pixelatomics.enable = 0
opencl.task.count = AUTO


RTPATHCPU

Code: Select all
# The default values
rtpathcpu.zoomphase.size = 4
rtpathcpu.zoomphase.weight = 0.1


RTPATHOCL

Code: Select all
# The default values
tilepath.sampling.aa.size = 1


TILEPATHCPU

Code: Select all
# The default values
tilepath.sampling.aa.size = 3


TILEPATHOCL

Code: Select all
# The default values
tilepath.sampling.aa.size = 3
tilepathocl.devices.maxtiles = 16
User avatar
Dade
Developer
 
Posts: 8318
Joined: Sat Apr 19, 2008 6:04 pm
Location: Italy

Re: LuxCore: render engine unification

Postby B.Y.O.B. » Thu May 11, 2017 11:57 am

I get a crash here when I only specify the engine as TILEPATHCPU without specifying a sampler.

This crashes:
Code: Select all
cfg_props.Set(pyluxcore.Property('renderengine.type', 'TILEPATHCPU'))

While this does not:
Code: Select all
cfg_props.Set(pyluxcore.Property('renderengine.type', 'TILEPATHCPU'))
cfg_props.Set(pyluxcore.Property('sampler.type', 'TILEPATHSAMPLER'))

I could also replicate this behaviour in the simple "bigmonkey" testscene from the repository, by using this minimal cfg file:
Code: Select all
# bigmonkey.cfg file
film.width = 640
film.height = 480
scene.file = bigmonkey.scn
renderengine.type = TILEPATHCPU
User avatar
B.Y.O.B.
Developer
 
Posts: 5095
Joined: Wed Nov 10, 2010 4:10 pm
Location: Germany

Re: LuxCore: render engine unification

Postby Dade » Thu May 11, 2017 11:59 am

B.Y.O.B. wrote:I get a crash here when I only specify the engine as TILEPATHCPU without specifying a sampler.


For crash, do you mean an exception with an error message or just plain crash ?
User avatar
Dade
Developer
 
Posts: 8318
Joined: Sat Apr 19, 2008 6:04 pm
Location: Italy

Re: LuxCore: render engine unification

Postby B.Y.O.B. » Thu May 11, 2017 12:25 pm

Just plain crash, not a runtime error.

By the way, the RTPATHOCL engine is crashing randomly here (for example when the film is resized or during other config updates).
Probably not related, just thought I'd mention it.
User avatar
B.Y.O.B.
Developer
 
Posts: 5095
Joined: Wed Nov 10, 2010 4:10 pm
Location: Germany

Previous

Return to Architecture & Design

Who is online

Users browsing this forum: No registered users and 2 guests