Small cmake issues

Discussion and help for Compilation problems and platform portability.

Moderator: coordinators

Re: Small cmake issues

Postby Carbonflux » Mon Jul 09, 2012 7:05 am

Depending on how you configure Qt it can drag in some openGL stuff which for example glx is part of etc. Excluding openGL from luxrays ( which needs openGL just to open a window in the case of SLG ) and lux is a different issue imo. Hopefully you are aware that openCL and openGL are different Qantourisc :) - you can tell by the GL/ vs the CL/
www.carbonflux.org - photographing the imagination.
User avatar
Carbonflux
Developer
 
Posts: 1394
Joined: Thu Aug 07, 2008 7:22 pm
Location: Seattle, WA, USA.

Re: Small cmake issues

Postby jeanphi » Mon Jul 09, 2012 10:04 am

Hi,

You're right Carbonflux, hopefully on a headless machine, you won't try to run luxrender but luxconsole only, so you should be safe.

Jeanphi
jeanphi
Developer
 
Posts: 6569
Joined: Mon Jan 14, 2008 7:21 am

Re: Small cmake issues

Postby Qantourisc » Tue Jul 10, 2012 7:35 am

jeanphi wrote:-march and -mtune, better be on the safe side, changing those to native will probably only bring a very marginal gain but might break compilation for users that might not be developers

- Unless there are bugs in the code, this works just fine, basicily all this does it try to optimize better for your cpu AND activate all other CPU options you have SSE4, etc...
- Imo it's quite stable (Gentoo user here, all my system (7) run on march=native (mtune is implied by march)).
- Gains will indeed probablly be marginal.

The biggest/real problem (IMO) are:
- the fact that you are producing bins that might not run on another machine.
- older GCC version don't know "native"
Qantourisc
 
Posts: 141
Joined: Mon May 17, 2010 2:37 pm

Re: Small cmake issues

Postby SATtva » Tue Jul 10, 2012 7:43 am

Qantourisc wrote:The biggest/real problem (IMO) are:
- the fact that you are producing bins that might not run on another machine.
- older GCC version don't know "native"

Precisely why i agree with jeanphi to keep flags on the safe side here so it compiles out-of-the-box on most systems.
Linux builds packager
聞くのは一時の恥、聞かぬのは一生の恥
User avatar
SATtva
Developer
 
Posts: 5487
Joined: Tue Apr 07, 2009 12:19 pm
Location: from Siberia with love

Re: Small cmake issues

Postby Qantourisc » Tue Jul 10, 2012 7:47 am

Suggested patch for luxrays as attachment.
If I did something wrong, please shout (in a friendly matter).
(I assumed GLUT and GLEW are not needed without OpenCL. Also I configured the paths in a dirty way, if there is a better way shout.)
Attachments
luxrays_opencl.patch
Patch
(2.33 KiB) Downloaded 27 times
Qantourisc
 
Posts: 141
Joined: Mon May 17, 2010 2:37 pm

Re: Small cmake issues

Postby jensverwiebe » Tue Jul 10, 2012 11:24 am

Sorry, i don`t accept your patch for several reasons.

You have logical issues, breaking flags, etc..
Better leave all as is in RC-phase.

Jens
User avatar
jensverwiebe
Developer
 
Posts: 2124
Joined: Wed Apr 02, 2008 4:34 pm

Re: Small cmake issues

Postby jeanphi » Tue Jul 10, 2012 3:54 pm

Hi,

I've pushed a set of changes based on Qantourisc ideas. It should now be easier to build for headless machines.

Jeanphi
jeanphi
Developer
 
Posts: 6569
Joined: Mon Jan 14, 2008 7:21 am

Re: Small cmake issues

Postby Carbonflux » Wed Jul 11, 2012 6:30 am

jeanphi wrote:I've pushed a set of changes based on Qantourisc ideas. It should now be easier to build for headless machines.


Thank you :)

I think this will help a lot because more people are using the computing cloud for rendering now.
www.carbonflux.org - photographing the imagination.
User avatar
Carbonflux
Developer
 
Posts: 1394
Joined: Thu Aug 07, 2008 7:22 pm
Location: Seattle, WA, USA.

Previous

Return to Compilation & Portability

Who is online

Users browsing this forum: Google [Bot] and 1 guest