Duplication de code : irregular SPD

Discussion related to the organization of the source code, repository and code-level/compiler optimization.

Moderators: Dade, coordinators

Duplication de code : irregular SPD

Postby Rom1 » Tue Jul 02, 2013 3:31 am

Hello there !

I found duplicated code for irregular spd :

luxrays\src\utils\sdl\spd.cpp line 136

and

lux\spds\irregular.cpp line 34

I don't have the last version, so it's probably merged and I would apologize for that ;)
Rom1
Developer
 
Posts: 110
Joined: Thu Feb 04, 2010 7:18 am

Re: Duplication de code : irregular SPD

Postby Dade » Tue Jul 02, 2013 4:05 am

The duplication was initial done (probably by Tomb) to implement SunSky for SLG (because at the time SLG wasn't part of LuxRender). There are few more small classes and function still duplicated even after LuxRays become a mandatory requirement for compiling Lux (like the one you spotted).

The really big target would be to use LuxRays accelerators in classic Lux (i.e. avoiding a lot code duplication across Lux and LuxRays). This would indeed require to extend LuxRays to handle all kind of primitives (at least on the CPU), not only triangles.
User avatar
Dade
Developer
 
Posts: 8404
Joined: Sat Apr 19, 2008 6:04 pm
Location: Italy


Return to Organization & Optimization

Who is online

Users browsing this forum: No registered users and 1 guest