Bug: saving an FLM file

[pciccone]

Sorry to post here but Mantis doesn't allow to post any new issues. Apparently it complains about a "Documentation update" mandatory field being blank. The field is not in the form.

Anyway, there is a bug in the Mac OS version of LuxRender that causes the forced closing of the File Save dialog bog when trying to save a FLM file while rendering. THere are the steps to reproduce it:

Environment: Lux 0.7RC3, Mac OS 10.6.3

- In LuxRender.app start a render, collect a few samples
- Click on File/Save FLM
- When the File Save dialog box shows, start typing a file name. Don't press enter or click on save.
- When the next refresh of the image happens the dialog box is forcibly closed. This is not what should happen.
- In several cases the saving silently failed because the closing of the dialog and menu coincided with the pressing of the Enter key.

Hope this helps.

[dougal2]

Sorry to post here but Mantis doesn't allow to post any new issues. Apparently it complains about a "Documentation update" mandatory field being blank. The field is not in the form.

I thought I'd fixed that this afternoon - please try again

[pciccone]

Sorry to report that it's still not accepting the entry.
The error message: A necessary field "Requires Documentation Update" was empty. Please recheck your inputs.
Also the "Select profile" row doesn't show any profile, but there are three fields for providing the OS information.

[jeanphi]

Also the "Select profile" row doesn't show any profile, but there are three fields for providing the OS information.

That's probably because you haven't defined your profile (there's no default).

Jeanphi

[dougal2]

Sorry to report that it's still not accepting the entry.
The error message: A necessary field "Requires Documentation Update" was empty. Please recheck your inputs.
Also the "Select profile" row doesn't show any profile, but there are three fields for providing the OS information.

OK, this appears to be a bug in the new version of mantis we upgraded to. It seems to require a hidden field to be filled in even though the settings say that it is not required for 'reporter' level users when reporting bugs.

Having previously only tested it as a 'developer' level user, it works as expected.

The only work around I can see for now is to lower the user level required to 'reporter' for usage of the custom fields we have set up.

[jensverwiebe]

Regarding the closing on an tonemapping-event, that was fixed by me some time ago.( 8 weeks ago, 3 commits )
I solved it by pausing the render when dialogs are open.
So you are definitely not using RC3 !

Jens

[pciccone]

Jens, the executable was downloaded from the RC3 link from the main page. The about box says RC3, released on June 6th. If there is another one I'll gladly test it.

[jensverwiebe]

Check again pls: OSX Lux should pause the render automatically on every filedialog. Mine does.( and i rechecked exactly the one i uploaded for all )
Result: a paused render does no tonemapping thus not closing the dialog. Can´t see any reason when this should fail.( But who knows )

See the codelines:

Code: Select all

void MainWindow::saveFLM()
{
   if( !luxStatistics("sceneIsReady") && !luxStatistics("filmIsReady") )
      return;
#if defined(__APPLE__)
   if(m_guiRenderState == RENDERING )
   pauseRender();
#endif
   if(m_guiRenderState == WAITING )
      return;

   QString flmFileName = QFileDialog::getSaveFileName(this, tr("Choose an FLM file to save to"), m_lastOpendir, tr("LuxRender FLM files (*.flm)"));
#if defined(__APPLE__)
   if(m_guiRenderState == PAUSED )
      resumeRender();
#endif
   if(flmFileName.isNull())
      return;


Your date looks right, btw, very strange.( LuxRender june 6th and console apps june 1th (last change on them ) )

Jens

[pciccone]

Jens, here is a video that shows the bug in action. I apologize for the poor quality, I don't have time for polish right now: http://www.preta3d.com/videos/lux_bugreport.mov
You can see that the "Render paused" message shows but the dialog goes away nevertheless. I swear I didn't press Esc
Hope this helps.

[jensverwiebe]

Ahaaaaaa... you didn´t mentioned you use networking

Hmmm, is there a special case preventing pausing ? Must check this, hold on.

Btw: in general this ugly behaviour was well known, thats why i introduced the pausing.

Edit: i found it:

Code: Select all

void MainWindow::pauseRender()
{
   if (m_guiRenderState != PAUSED && m_guiRenderState != TONEMAPPING) {
      // We have to check if network rendering is enabled. In this case,
      // we don't stop timer in order to save the image to the disk, etc.
      if (luxGetServerCount() < 1) {
         m_renderTimer->stop();
         m_statsTimer->stop();
      }
      
      if (m_guiRenderState == RENDERING)
         luxPause();

      changeRenderState(PAUSED);
   }
}

I must find a way to explicitly stop the timers then even whth networking on.


Jens