patlecoq wrote:Hi,
Jens, I have a few remarks on the GUI:
The gradient you have added to the pane widget works fine even under Windows:
If think you can remove the #if defined(__APPLE__) for it.
With the gradient, when the pane is switched off, it is not easy to see the switch button.
If the right of the gradient is changed to rgb(90, 90, 90) instead of rgb(120, 120, 120), I think it is better:
Under Windows, the resolution information labels are too wide:
Under MacOS, it looks OK because you use a bigger font.
If you remove the minimumSize value for these labels, their size is automatically ajusted to the text size:
Under Windows, there is a space between the progress bar and the statistics:
I have not found any reason for this in the code. It might be a Qt bug under Windows, as it is OK under MacOS.
There is a not needed space below the Gamma panel:
Without the spacer, it looks nicer:
Regards.
Patrice
Comes a bit late for RC3, dunno if i will commit fixes still, jeanphi suggested to freeze atm.
In general:
--> gradient: must be cleared up if it looks o.k and is wanted on other OS too, can´t remove ifdef simply, perhaps for OSX/win then, but: first take user-opinions on that.
--> gradient range: nope, will give a too hard contrast ( and would be darker than renderview BG) , then the poweroff-icon must be changed to slightly brighter
--> gamma, o.k. with that --->commited
--> resolution/zoom/.., o.k. with that.--->commited
--> space after progressbar: dunno exactly, does not happen on OSX, but here i let the box filled, whereas Tom disables showing the progressbar on other OS, cause it looks half-filled there.
Be aware there are OS-differences in Qt too ( native parts ), so always restrict such changes only to the tested OS.
Jens
P.S.: just noticed: 1000th post
)
