jeanphi wrote:...and ERPT could as well be removed...
jeanphi wrote: - when calling a baseSampler member, first replace the sample data pointer by the baseSampler data pointer, do the call, put back the ERPTSampler data pointer
Lord Crc wrote:I agree that we should seriously consider retiring the erpt.
Lord Crc wrote:Pushed the fugly hack.
I agree that we should seriously consider retiring the erpt. Since AddSampleCount can't be moved it's not at all compatible in terms of haltspp compared to the other samplers, it has issues with fireflies (due to random/ld base sampler), and there's no significant advantage over mlt as mentioned. It also doesn't fit very well into the current framework (as witnessed just now).
I think we should not change the feature set now. I agree this might not make a difference, but who knows, better wait v0.9 for that.
Users browsing this forum: No registered users and 2 guests