Camera response functions as a tonemapping option

[jeanphi]

Hi,

Especially if there are hundreds of data sets, I think we should rely on files
I don't think it's worth restricting the function to the linear tonemapper (it's even going to be almost impossible).
Regarding PBRT, I don't know your math knowledge, but it's a very valuable book which takes one step at a time trying to explain thinks in a pragmatic way so I find it a much better introduction than a paper like Veach's thesis which is another great reference but much more abstract.

Jeanphi

[tomb]

Hi,

Especially if there are hundreds of data sets, I think we should rely on files
I don't think it's worth restricting the function to the linear tonemapper (it's even going to be almost impossible).
Regarding PBRT, I don't know your math knowledge, but it's a very valuable book which takes one step at a time trying to explain thinks in a pragmatic way so I find it a much better introduction than a paper like Veach's thesis which is another great reference but much more abstract.

Jeanphi

Indeed. And be sure you get the 2nd edition, not the 1st!

[Daniel90]

Here I have some crf files (the ones that were used for the examples with the macbeth chart a few posts back):

PS: I'll get the pbrt book. second edition but not until in a month

[jeanphi]

Hi,

I've reworked a bit this code and integrated it.
You can't yet change the function at run time but the basic functionality is there.

Jeanphi

[patrickwalz]

nice to see this function worked its way into the code base -- do we need any help cleaning up the database of response functions? i was looking at it and noticed some of the data is grouped rather strangely and i believe daniel saying something about some of the response functions dont have all the data?

[dougal2]

I pushed a fix to prevent crash if the CRF file is invalid; I also re-arranged things a minimal amount to allow it to be changed at run time via the queryable interface ('film', 'CameraResponse').

[SATtva]

Am I the only one receiving this on Linux?

Code: Select all

[ 30%] Building CXX object CMakeFiles/lux.dir/film/fleximage.o
/root/luxbuild/lux-v08dev-101109-820c67a00ef2/film/fleximage.cpp: In member function 'void lux::FlexImageFilm::WriteImage2(lux::ImageType, std::vector<lux::XYZColor, std::allocator<lux::XYZColor> >&, std::vector<float, std::allocator<float> >&, std::string)':
/root/luxbuild/lux-v08dev-101109-820c67a00ef2/film/fleximage.cpp:872: error: 'class lux::CameraResponse' has no member named 'fileName'
[ 31%] Building CXX object CMakeFiles/lux.dir/filters/gaussian.o
make[2]: *** [CMakeFiles/lux.dir/film/fleximage.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/lux.dir/all] Error 2
make: *** [all] Error 2


[jensverwiebe]

Nope, Lords last commit is culprit --> investigating whats wrong atm...

EDIT:
Dunno what Lord wanted explicitly, but here´s a dirty compilefix:

Code: Select all

diff -r 820c67a00ef2 core/cameraresponse.h
--- a/core/cameraresponse.h   Tue Nov 09 06:55:56 2010 +0100
+++ b/core/cameraresponse.h   Tue Nov 09 12:46:36 2010 +0100
@@ -31,7 +31,7 @@
public:
   CameraResponse(const string &film);
   void Map(RGBColor &rgb) const;
-
+   string crfFile;
   bool validFile;
private:
   float ApplyCrf(float point, const vector<float> &from, const vector<float> &to) const;
diff -r 820c67a00ef2 film/fleximage.cpp
--- a/film/fleximage.cpp   Tue Nov 09 06:55:56 2010 +0100
+++ b/film/fleximage.cpp   Tue Nov 09 12:46:36 2010 +0100
@@ -869,7 +869,7 @@
         if (response == "")
            cameraResponse.reset();

-         if ((!cameraResponse && response != "") || (cameraResponse && cameraResponse->fileName != response))
+         if ((!cameraResponse && response != "") || (cameraResponse && cameraResponse->crfFile != response))
            cameraResponse.reset(new CameraResponse(response));

         crf = cameraResponse;

Jens

[SATtva]

Thanks Jens, that fixed the compilation.

[Lord Crc]

Arrrgh, sorry again guys, need to clean up my repo, way too many local changes to keep track of

edit: pushed the missing files.

edit2: made my very own clone repo for all local mods, keeping the main one clean, this won't happen again...