LuxCore: new features

Discussion related to the implementation of new features & algorithms to the Core Engine.

Moderators: Dade, jromang, tomb, zcott, coordinators

Re: LuxCore: new features

Postby neo2068 » Sun Sep 11, 2016 11:35 pm

jensverwiebe wrote:Whoohooo, thx :)

Compiled fine on Linux with clang too, testing asap.

Btw: i suspect an actual prob with bidir anyway, see my ies tests, area/material emsiion looks wrong with ies.

Edit: could not yet see a problem with bidir and pano, whats the prob ?

Jens

There is a problem with lightcpu engine (see images from kalel) and since the lighttrace part of bidir shares some code with lightcpu I thought that there is a problem, too. Orthographic camera also has this problem with lightcpu and sometimes there are double images with bidir. I think that's the same problem. First, I have to understand the code to track down the issue. Perhaps some wrong code in GetSamplePosition/SampleLens or some wrong camera matrices. :?:
i7 5820K, 32 GB RAM, NVIDIA Geforce GTX 780 + GTX 560, Windows 10 64bit, Blender 2.77a
neo2068
Developer
 
Posts: 742
Joined: Sun May 03, 2009 2:11 am
Location: Germany

Re: LuxCore: new features

Postby Dade » Mon Sep 12, 2016 7:35 am

Do you have a test scene showing the problem ? And what problem is exactly ?
User avatar
Dade
Developer
 
Posts: 8404
Joined: Sat Apr 19, 2008 6:04 pm
Location: Italy

Re: LuxCore: new features

Postby acasta69 » Mon Sep 12, 2016 8:25 am

Dade wrote:Do you have a test scene showing the problem ? And what problem is exactly ?

For what regards the orthographic camera, you can find more info at these links:
http://www.luxrender.net/mantis/view.php?id=1647
http://www.luxrender.net/forum/viewtopic.php?f=8&t=11306&start=730#p123190
Windows 10 64 bits, i7-4770 3.4 GHz, RAM 16 GB, GTX 970 4GB v382.05
acasta69
 
Posts: 299
Joined: Fri Dec 20, 2013 3:18 am

Re: LuxCore: new features

Postby neo2068 » Mon Sep 12, 2016 12:27 pm

Dade wrote:Do you have a test scene showing the problem ? And what problem is exactly ?

The problem is visible with orthographic and environment camera with every scene and lightcpu engine. Simply change the camera type in the standard luxball scene to orthographic or environment and the render engine to lightcpu. with bidir it's not so obvious and occurs only at certain circumstancies.
ortho_pathcpu.png
orthographic camera and pathcpu render engine

ortho_lightcpu.png
orthographic camera and lightcpu render engine
ortho_lightcpu.png (8.71 KiB) Viewed 924 times

env_pathcpu.png
environment camera and pathcpu render engine

env_lightcpu.png
environment camera and lightcpu render engine
i7 5820K, 32 GB RAM, NVIDIA Geforce GTX 780 + GTX 560, Windows 10 64bit, Blender 2.77a
neo2068
Developer
 
Posts: 742
Joined: Sun May 03, 2009 2:11 am
Location: Germany

Re: LuxCore: new features

Postby jensverwiebe » Wed Sep 14, 2016 8:44 am

Added environment camera to luxcorerenderer, trying also to add ortho tonight.

screenshot-window-2016-09-14-165827.png


Jens
User avatar
jensverwiebe
Developer
 
Posts: 3429
Joined: Wed Apr 02, 2008 4:34 pm

Re: LuxCore: new features

Postby jensverwiebe » Wed Sep 14, 2016 9:54 am

Added also ortho camera.
screenshot-window-2016-09-14-183936.png


Edit: the oddnes i experienced first was caused by Blender.




Jens
User avatar
jensverwiebe
Developer
 
Posts: 3429
Joined: Wed Apr 02, 2008 4:34 pm

Re: LuxCore: new features

Postby neo2068 » Wed Sep 14, 2016 11:11 pm

Thanks, Jens. :D

Dade, do you have an idea what could cause the issues with lightcpu? I tried to investigate the problem with orthographic camera since it shares the code with perspective camera but I have not found anything yet.
i7 5820K, 32 GB RAM, NVIDIA Geforce GTX 780 + GTX 560, Windows 10 64bit, Blender 2.77a
neo2068
Developer
 
Posts: 742
Joined: Sun May 03, 2009 2:11 am
Location: Germany

Re: LuxCore: new features

Postby Dade » Thu Sep 15, 2016 4:26 am

neo2068 wrote:Dade, do you have an idea what could cause the issues with lightcpu? I tried to investigate the problem with orthographic camera since it shares the code with perspective camera but I have not found anything yet.


There were few problems:

1) the usage of Inverse(camTrans.rasterToWorld) instead of Inverse(camTrans.cameraToWorld);

2) LuxCore film Y is flipped compared to classic Lux, this required some fix around the code;

3) LIGHTCPU/BIDIRCPU were assuming to work with a projective camera so the camera PDF was wrong (i.e. negative values causing a mess) in the case of environment camera. I have extended the camera class interface to handle custom camera PDFs.

Now the environment camera seems to works fine with LIGHTCPU/BIDIRCPU too.

P.S. I have yet to fix the ortho camera because it is a different problem.
User avatar
Dade
Developer
 
Posts: 8404
Joined: Sat Apr 19, 2008 6:04 pm
Location: Italy

Re: LuxCore: new features

Postby sharlybg » Thu Sep 15, 2016 9:27 am

jensverwiebe wrote:Added environment camera to luxcorerenderer, trying also to add ortho tonight.

screenshot-window-2016-09-14-165827.png


Jens


thanks you so much ! its very interresting to see developement progress. :D
i7 6700k + 32 Gb DDR4 + 2X R9 390 sapphir nitro.
User avatar
sharlybg
 
Posts: 730
Joined: Tue Nov 02, 2010 10:22 am
Location: Ivory coast

Re: LuxCore: new features

Postby jensverwiebe » Thu Sep 15, 2016 10:44 am

sharlybg wrote:
jensverwiebe wrote:Added environment camera to luxcorerenderer, trying also to add ortho tonight.

screenshot-window-2016-09-14-165827.png


Jens


thanks you so much ! its very interresting to see developement progress. :D


Its more kinda backporting. But i know many ppl still like to work with Lux Gui like me and have networking and resume.
Perhaps we should open a thread to have this under control aka collect what luxcore features are missing in luxcorerenderer
( gah slg was such a nice short term :shock: ) and i try to port then whats possible. Not all will !!!

Jens
User avatar
jensverwiebe
Developer
 
Posts: 3429
Joined: Wed Apr 02, 2008 4:34 pm

PreviousNext

Return to Architecture & Design

Who is online

Users browsing this forum: No registered users and 2 guests