LuxCore: new features

Discussion related to the implementation of new features & algorithms to the Core Engine.

Moderators: Dade, jromang, tomb, zcott, coordinators

Re: LuxCore: new features

Postby neo2068 » Thu Sep 15, 2016 12:37 pm

Dade wrote:
neo2068 wrote:Dade, do you have an idea what could cause the issues with lightcpu? I tried to investigate the problem with orthographic camera since it shares the code with perspective camera but I have not found anything yet.


There were few problems:

1) the usage of Inverse(camTrans.rasterToWorld) instead of Inverse(camTrans.cameraToWorld);

2) LuxCore film Y is flipped compared to classic Lux, this required some fix around the code;

3) LIGHTCPU/BIDIRCPU were assuming to work with a projective camera so the camera PDF was wrong (i.e. negative values causing a mess) in the case of environment camera. I have extended the camera class interface to handle custom camera PDFs.

Now the environment camera seems to works fine with LIGHTCPU/BIDIRCPU too.

P.S. I have yet to fix the ortho camera because it is a different problem.

Thank you for looking into the problem.
i7 5820K, 32 GB RAM, NVIDIA Geforce GTX 780 + GTX 560, Windows 10 64bit, Blender 2.77a
neo2068
Developer
 
Posts: 742
Joined: Sun May 03, 2009 2:11 am
Location: Germany

Re: LuxCore: new features

Postby Dade » Fri Sep 16, 2016 4:11 am

I should have fixed also LIGHTCPU and BIDIRCPU rendering with orthographic camera.
User avatar
Dade
Developer
 
Posts: 8404
Joined: Sat Apr 19, 2008 6:04 pm
Location: Italy

Re: LuxCore: new features

Postby jensverwiebe » Fri Sep 16, 2016 4:38 am

Dade wrote:I should have fixed also LIGHTCPU and BIDIRCPU rendering with orthographic camera.


Confirm, looks good now , thx.

We have a last bidir oddness remaining with ies mesh-lighs:

screenshot-area-2016-09-16-124229.png
bidir, mesh - area - pointlight


..whereas path looks correct:

screenshot-area-2016-09-16-124246.png
pathr, mesh - area - pointlight


EDIT: exported testscene ( cfg/scn; ... ):
test_ies.zip
(10.38 KiB) Downloaded 43 times


Jens
Last edited by jensverwiebe on Mon Sep 19, 2016 10:05 am, edited 1 time in total.
User avatar
jensverwiebe
Developer
 
Posts: 3429
Joined: Wed Apr 02, 2008 4:34 pm

Re: LuxCore: new features

Postby acasta69 » Fri Sep 16, 2016 9:11 am

Thanks Dade, double images with Bidir+Ortho have gone now, however lighting with that combination looks different (I'm not using IES lights though):

ortho_bidir_2.png
Bidir + Ortho

ortho_path_2.png
Path + Ortho

persp_bidir_2.png
Bidir + Perspective

persp_path_2.png
Path + Perspective
Windows 10 64 bits, i7-4770 3.4 GHz, RAM 16 GB, GTX 970 4GB v382.05
acasta69
 
Posts: 299
Joined: Fri Dec 20, 2013 3:18 am

Re: LuxCore: new features

Postby Dade » Mon Sep 19, 2016 8:50 am

jensverwiebe wrote:
Dade wrote:I should have fixed also LIGHTCPU and BIDIRCPU rendering with orthographic camera.


Confirm, looks good now , thx.

We have a last bidir oddness remaining with ies mesh-lighs:


Jens, but is it a problem related to the ortho camera problem or to the IES problem discussed in another thread ? i have the doubt because it seems related to the other problem but you quoted my message related to the ortho camera ?
User avatar
Dade
Developer
 
Posts: 8404
Joined: Sat Apr 19, 2008 6:04 pm
Location: Italy

Re: LuxCore: new features

Postby Dade » Mon Sep 19, 2016 8:51 am

acasta69 wrote:Thanks Dade, double images with Bidir+Ortho have gone now, however lighting with that combination looks different (I'm not using IES lights though):


Ok, this is likely to be another problem in ortho camera PDF, going to check...
User avatar
Dade
Developer
 
Posts: 8404
Joined: Sat Apr 19, 2008 6:04 pm
Location: Italy

Re: LuxCore: new features

Postby jensverwiebe » Mon Sep 19, 2016 9:21 am

Dade wrote:
jensverwiebe wrote:
Dade wrote:I should have fixed also LIGHTCPU and BIDIRCPU rendering with orthographic camera.


Confirm, looks good now , thx.

We have a last bidir oddness remaining with ies mesh-lighs:


Jens, but is it a problem related to the ortho camera problem or to the IES problem discussed in another thread ? i have the doubt because it seems related to the other problem but you quoted my message related to the ortho camera ?


Right, its related to bidir/ies only, but we discussed in this thread too cause i posted the port results here ( luxcorerenderer ). Sorry for the confusion.
Anyway, seems we have an issue in bidir basically ?

Jens
User avatar
jensverwiebe
Developer
 
Posts: 3429
Joined: Wed Apr 02, 2008 4:34 pm

Re: LuxCore: new features

Postby Dade » Mon Sep 19, 2016 9:40 am

Dade wrote:
acasta69 wrote:Thanks Dade, double images with Bidir+Ortho have gone now, however lighting with that combination looks different (I'm not using IES lights though):


Ok, this is likely to be another problem in ortho camera PDF, going to check...


I should have fixed this problem.
User avatar
Dade
Developer
 
Posts: 8404
Joined: Sat Apr 19, 2008 6:04 pm
Location: Italy

Re: LuxCore: new features

Postby Dade » Mon Sep 19, 2016 9:41 am

jensverwiebe wrote:Right, its related to bidir/ies only, but we discussed in this thread too cause i posted the port results here ( luxcorerenderer ). Sorry for the confusion.
Anyway, seems we have an issue in bidir basically ?


You mean the output of BiDir+IES light source is currently different from Path+IES ? Ok, I will check.
User avatar
Dade
Developer
 
Posts: 8404
Joined: Sat Apr 19, 2008 6:04 pm
Location: Italy

Re: LuxCore: new features

Postby jensverwiebe » Mon Sep 19, 2016 10:04 am

Dade wrote:
jensverwiebe wrote:Right, its related to bidir/ies only, but we discussed in this thread too cause i posted the port results here ( luxcorerenderer ). Sorry for the confusion.
Anyway, seems we have an issue in bidir basically ?


You mean the output of BiDir+IES light source is currently different from Path+IES ? Ok, I will check.

yes, this:http://www.luxrender.net/forum/viewtopic.php?f=16&t=13056&sid=70211eed49515f0a96cf2208beba6733#p124009
Afaik posted a testfile .. lemme find it back...


EDIT: viewtopic.php?f=8&t=10673&p=124162&sid=70211eed49515f0a96cf2208beba6733#p124162

Jens
User avatar
jensverwiebe
Developer
 
Posts: 3429
Joined: Wed Apr 02, 2008 4:34 pm

PreviousNext

Return to Architecture & Design

Who is online

Users browsing this forum: No registered users and 2 guests