GUI Prototyping thread...

[Carbonflux]

hi jeanphi...

I am not sure about the idea of altering the lxs file after start up, I have heard it thrown around so I added all the possible options, I will remove it, its easy to add later.

I am not sure what you mean by direct access to the number of threads? you mean move it back onto the toolbar?

Thats no problem of course but I saw it as a little used option, I have not had much success using it after a render is started personally, normally I end up segfaulting lux when playing around with it, I figured the best way to deal with was put it in a options dialog. But it would be easy to move back

Also I was thinking it might be nice to add a auto-detect button etc.

[dougal2]

Having the number of threads on the toolbar is very useful, I use it all the time.
Also, recent versions of Lux do auto-detect the number of threads on startup if it's not given on the command line.

[Radiance]

I agree that the thread control needs to stay
I often use it when juggling multiple lux'en around when working

However i find the current wxspinctl extremely annoying...
Maybe you can find a more elegant control (like what we had in the previous GUI)

Radiance

[Carbonflux]

ok, I think I understand now thank you

Should we lose all the spin controls btw?

I will take a look at the old UI and covert it to something wx and put it back on the toolbar.

[Radiance]

Just make it so that you can't add new thread VERY fast as with the current one. (eg you can go from 1 to 10 threads in 1 second by clicking very fast 9 times), which can cause crashes.
The old one had a pulldown menu for adding one which seemed to give the user some spaces between adding more than 1 in time terms...

Radiance

[Carbonflux]

ah ok, that must have been what happened to me also when just playing with it, I could reduce the number of threads without crashing but it would crash sometimes when adding them, this gives rise to several thoughts, ie; leave the spin control but add a delay and a "thread starting...." message in the status bar, a pull down would be no problem either or even check the flags on the spin control itself and see if there is a way to get it to ignore holding down the mouse and only process one click at a time, I suspect whats going on is some kind of race condition that makes it think the mouse is being held down.

I updated my notes and plan on working on the UI for several hours tonight and tomorrow, thanks for raising the issue

[jeanphi]

Hi,

Better solution would be to find why it crashes and fix this. I'll try to have a look at it one day

Jeanphi

[Carbonflux]

well, I went in and looked at the behavior of the control itself and its hyper-sensitive, I noticed there were icons already for plus and minus, not sure what was planned for those but I could make them into buttons for the thread controls and only inc the number of threads on mouse up. I need to take another pass to see if I can get the spin control to "slow" down before giving up on it tho

[Carbonflux]

Here is a example of a alternative for the thead control which seems to be "slow" enough....

for some reason its scaling this image so its larger then the original, it really does not look this ugly ;)

lux.ui.thread.1.png (9.49 KiB) Viewed 353 times

You just press plus or minus to add threads one at a time, its all hooked up and working in my test version and "seems" to be fine.

Also, I learned how to add icons as you can see by the copy icon, please let me know if its wrong, I can keep redoing the icons until they are correct if there is a need for that

All the tone mapping controls are hooked up and "working" I plan on posting the diff's and describing the member vars for the current state of things sometime tomorrow night if possible.

Please let me know if this new threading interface is ok, I can attack the spin control at a deeper level and hook some of the mouse down messages also and maybe fix it that way or change it to a combo box np.

[zsouthboy]

Looks good!
I suggest a "blinking ethernet hub" or something to that effect for the Network tab icon The current one is ambigious.